Re: Network-related Oopses on 2.2.13pre14

Andi Kleen (ak@muc.de)
Mon, 4 Oct 1999 01:38:37 +0200

On Mon, Oct 04, 1999 at 12:34:15AM +0200, Andrea Arcangeli wrote:
> On 4 Oct 1999, Andi Kleen wrote:
>
> >I don't expect it to fix any problems. Interrupts never remove packets
> >from the backlog, only add them. dev_clear_backlog is protected against other
>
> The fact that it's only adding elements is just too much to be safe.
>
> We are walking a list that can change under us.

[...]

Ok, point taken.

I don't like your fix though. skb_queue_lock is far too fundamental to
be taken that long, especially over a kfree_skb(). e.g. if the skb destructor
does any skb list operations it'll deadlock. so it would be better to enforce
the ordering in skb_queue_tail.

-Andi

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/