Yes, but I wanted to try 2.2.13pre15 as soon as possible.
There were three rejects, in ide.c. Two were for the spinlock (which therefore was not changed in pre15, I also checked it), the other was:
***************
*** 1539,1552 ****
}
spin_unlock_irqrestore(&io_request_lock, flags);
do_hwgroup_request(hwgroup);
- save_flags(flags); /* all CPUs; overkill? */
- cli(); /* all CPUs; overkill? */
if (action == ide_wait)
{
down(&sem); /* wait for it to be serviced */
rq->sem = NULL;
}
- restore_flags(flags); /* all CPUs; overkill? */
return rq->errors ? -EIO : 0; /* return -EIO if errors */
}
--- 1648,1658 ----
}
spin_unlock_irqrestore(&io_request_lock, flags);
do_hwgroup_request(hwgroup);
if (action == ide_wait)
{
down(&sem); /* wait for it to be serviced */
rq->sem = NULL;
}
return rq->errors ? -EIO : 0; /* return -EIO if errors */
}
I.e.: In the kernel I tested, the "/* all CPUs; overkill? */" lines are still there, and "rq->sem = NULL;" is missing. Please tell me if you believe that any of these is a problem.
Anyway, that kernel was the one that survived longest (6 hours, until it had a NULL pointer dereference). My 2.2.13pre15 without UnifiedIDE locked up hard after 4 hours. The pre15 kernel with UnifiedIDE was not less reliable, but perhaps more.
>If you got any "fuzz" or single line rejects.......
No fuzz, just a few small offsets. Besides the above rejects your 2.2.13pre14 patch applies cleanly to pre15.
-- the online community service for gamers & friends - http://www.rivalnet.com * unterstützt über 50 PC-Spiele im Multiplayer-Modus * Dateien senden & empfangen bis 500 MB am Stück * Newsgroups, Mail, Chat & mehr- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/