Re: PCI patch for 2.3.19

Ivan Kokshaysky (ink@jurassic.park.msu.ru)
Wed, 6 Oct 1999 20:40:09 +0400


Hi!

On Wed, Oct 06, 1999 at 12:05:01PM +0200, Martin Mares wrote:
> I've just uploaded my new PCI patch against 2.3.19 at
> ftp://atrey.karlin.mff.cuni.cz/pub/linux/pci/alpha/l-pci-2.3.19-1.gz.

Your code in pci_fixup_ide_bases() is incorrect for most [non-intel]
IDE chipsets. I think this one will work in 100% cases:

for(i=0; i<4; i++) {
struct resource *r = &d->resource[i];
if ((r->start & ~0x80) == 0x374) {
r->start += 2;
r->end = r->start;
}
}

I also think that following small change is needed for ide-pci.c:

--- 2.3.18ac9/drivers/block/ide-pci.c Tue Sep 7 22:23:40 1999
+++ linux/drivers/block/ide-pci.c Tue Oct 5 20:22:41 1999
@@ -507,7 +507,7 @@
if ((hwif = ide_match_hwif(base, d->bootable, d->name)) == NULL)
continue; /* no room in ide_hwifs[] */
if (hwif->io_ports[IDE_DATA_OFFSET] != base) {
- ide_init_hwif_ports(&hwif->hw, base, (ctl + 2), NULL);
+ ide_init_hwif_ports(&hwif->hw, base, (ctl | 2), NULL);
memcpy(hwif->io_ports, hwif->hw.io_ports, sizeof(hwif->io_ports));
hwif->noprobe = !hwif->io_ports[IDE_DATA_OFFSET];
}

Ivan.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/