Re: serial.c patch in 2.3.19

Theodore Y. Ts'o (tytso@mit.edu)
Sat, 16 Oct 1999 13:02:28 -0400


Date: Fri, 15 Oct 1999 19:49:24 +0100
From: Nick Holloway <Nick.Holloway@alfie.demon.co.uk>

I submitted the patch originally. Otherwise it would release the resource
that wasn't held for the port I don't have.

I think the problem is that when deciding if to release the port, it
considers the _new_ setting of the state->type. Thus, when you change
the uart to "none", the previous allocation is not released.

I think the following (untested) patch should remedy this. My brain
is having trouble thinking around this, but the check for releasing the
region uses the same values used for requesting the region.

A similar change is already in the 2.3 serial driver (and in the 4.90
driver, which will work on either the 2.2 or 2.3 kernel ---
http://web.mit.edu/tytso/www/linux/serial). So yeah, that should fix
it. So yeah, it should probably fix things. (Sorry, I didn't realize
the folks who were complaining where using the 2.2 kernel.)

Once I do a bit more testing, I'll be submitting the newer serial driver
to Alan for inclusion into the 2.2 kernel.

- Ted

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/