Re: ide-cd underestimates NEC260 CDROM drive.
Jens Axboe (axboe@image.dk)
Mon, 25 Oct 1999 18:13:34 +0200
On Mon, Oct 25 1999, David Woodhouse wrote:
> The latest version of ide-cd.c has a special case for the NEC 260 drive and
> doesn't attempt to query its capabilities. Unfortunately, it doesn't actually
> set the known capabilities of the driver either.
>
> To reenable the support for audio and eject on this drive, I need the following
> patch (against 2.2.13):
>
> Index: ide-cd.c
> ===================================================================
> RCS file: /cvs/linux/drivers/block/ide-cd.c,v
> retrieving revision 1.4
> diff -u -w -r1.4 ide-cd.c
> --- ide-cd.c 1999/09/13 11:34:31 1.4
> +++ ide-cd.c 1999/10/25 11:01:03
> @@ -2890,8 +2890,11 @@
> struct atapi_capabilities_page cap;
> } buf;
>
> - if (CDROM_CONFIG_FLAGS (drive)->nec260)
> + if (CDROM_CONFIG_FLAGS (drive)->nec260) {
> + CDROM_CONFIG_FLAGS (drive)->no_eject = 0;
> + CDROM_CONFIG_FLAGS (drive)->audio_play = 1;
> return nslots;
> + }
The special case for nec260 was always there, it's just that in
2.2.13 the setup changed a bit wrt audioplay/eject. NEC 260
drives were never probed, I suppose they fail or don't support
the capabilities page at all. The patch looks good, though.
Alan, could you apply?
--
* Jens Axboe <axboe@image.dk>
* Linux CD-ROM Maintainer
* http://www.kernel.dk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/