Re: [PATCH] four warnings and a patch

Michael Hunold (kernel@kvack.org)
Thu, 28 Oct 1999 17:55:52 -0400 (EDT)


On Thu, 28 Oct 1999, Dennis Hou wrote:

> On Thu, 28 Oct 1999, Rik van Riel wrote:
>
> > On Thu, 28 Oct 1999, Dennis Hou wrote:
> >
> > > Can somebody more knowledgable about the above please get these warnings
> > > out? After all, perfect compilation is the first step to a Good kernel.
> >
> > Basically, your patches remove variables that are not referenced
> > on UP systems. This will kill any SMP compilation (let alone boot).
> > Let's just hope Linus doesn't die laughing.
>
> What are you talking about? There is only one line in the patch:
>
> - struct ei_device *ei_local = (struct ei_device *) dev->priv;

Which is very broken: it breaks non-x86 architechures that share the
8390.c code.

-ben

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/