Re: 2.3.27 PATCH fixing unbalanced #endif in drivers/scsi/ini9100u.h

Alexander Viro (viro@math.psu.edu)
Fri, 12 Nov 1999 07:16:20 -0500 (EST)


On Fri, 12 Nov 1999, Adam J. Richter wrote:

> >> = Adam Richter
> > = Alexander Viro
>
> >> The subject line says it all. drivers/scsi/init9100u.h has an
> >> unbalanced #endif. Here is a patch to make it compile.
>
> >Wrong fix, actually. Correct one: remove extern and #endif (and don't
> >include config.h, indeed).
>
> Oops! You're right. I had thought that the proc filesystem data
> structures were only defined if CONFIG_PROC_FS is set, but inspection
> of include/linux/proc_fs.h releaved that that is not the case, so

;-) Irrelevant, since proc_scsi_* is no more. Kinda silly to leave externs
after that... I removed the remaining externs of that kind, but there may
be other problems with drivers/scsi stuff - patch was large and there was
no way to compile them all afterwards (to start with, quite a few are
architecture-specific). So there may be dragons.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/