Re: PATCH for FAT in 2.3.28

Alexander Viro (viro@math.psu.edu)
Sat, 13 Nov 1999 13:28:37 -0500 (EST)


On Sat, 13 Nov 1999, Martin Dalecki wrote:

> The following is fixing the compilation of the fat FS as a runtime
> loadable
> module. I have tested the patch on my ZIP drive. Apparently there is
> only
> one one other filesystem out there which is using the same partial page
> write interface, which appears as a leftover from older VFS versions.

Wrong.

> (At least for fat I can't see what the special function was doing
> different
> then the generic one. At least it didn't touch any special FAT fields in
> the inode.)

Watch carefully. FAT (_and_ HPFS) doesn't allow files with holes. First of
all it _does_ touch FAT-specific fields (albeit i_size) would probably be
OK with some tweaking. Yes, it might make sense to move it into buffer.c.
But it's _not_ an equivalent of the generic one. Heck, have you ever tried
the result of your changes?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/