Re: Linux 2.2.14pre5

Urban Widmark (urban@svenskatest.se)
Sat, 13 Nov 1999 21:31:22 +0100 (CET)


This message is in MIME format. The first part should be readable text,
while the remaining parts are likely unreadable without MIME-aware tools.
Send mail to mime@docserver.cac.washington.edu for more info.

---1463780587-1719613331-942525082=:14414
Content-Type: TEXT/PLAIN; charset=US-ASCII

On Sat, 13 Nov 1999, Alan Cox wrote:

> o SMBfs long directory fix (Pete Hilton)

This one looks incomplete to me. It only changes the "findfirst" call and
not the "findnext" to not ask for resume keys. I don't see why they should
be sent with different flags. I ran into this problem myself a few weeks
ago.

There is a related bug with the filename "mask". smbfs does not get the
pointer to the last transfered name right (it has a pointer to a record,
but reads it as the actual name). For me samba servers stopped handling
(some) long dirs correctly when removing the "resume required" flag and
not also fixing the mask. The NTs tested did not seem to care.

I have a testcase on:
http://www.hojdpunkten.ac.se/054/samba/samba-dir.zip
(unpack on the server, then look at it with smbfs)

Attached is my version of solving the same problem. I have previously
posted this patch to the samba mailinglist. I did not send it to the
maintainer, I wanted to feel more certain that it worked (since I don't
really know _why_ the resumekey flag should be removed ... except that the
keys are always 0 ...)

Patch was made for 2.2.12, but should still apply.

/Urban

---1463780587-1719613331-942525082=:14414
Content-Type: TEXT/PLAIN; charset=US-ASCII; name="smbfs-resume.patch"
Content-Transfer-Encoding: BASE64
Content-ID: <Pine.LNX.4.10.9911132131220.14414@cola.svenskatest.se>
Content-Description:
Content-Disposition: attachment; filename="smbfs-resume.patch"

ZGlmZiAtdXIgbGludXgtMi4yLjEyLWNsZWFuL2ZzL3NtYmZzL3Byb2MuYyBs
aW51eC9mcy9zbWJmcy9wcm9jLmMNCi0tLSBsaW51eC0yLjIuMTItY2xlYW4v
ZnMvc21iZnMvcHJvYy5jCVNhdCBPY3QgMjMgMTc6NDQ6NTQgMTk5OQ0KKysr
IGxpbnV4L2ZzL3NtYmZzL3Byb2MuYwlTYXQgT2N0IDIzIDIyOjI1OjQ5IDE5
OTkNCkBAIC0xNTk5LDggKzE1OTksNyBAQA0KIAkJCWNvbW1hbmQgPSBUUkFO
U0FDVDJfRklOREZJUlNUOw0KIAkJCVdTRVQocGFyYW0sIDAsIGFTWVNURU0g
fCBhSElEREVOIHwgYURJUik7DQogCQkJV1NFVChwYXJhbSwgMiwgbWF4X21h
dGNoZXMpOwkvKiBtYXggY291bnQgKi8NCi0JCQlXU0VUKHBhcmFtLCA0LCA4
ICsgNCArIDIpOwkvKiByZXN1bWUgcmVxdWlyZWQgKw0KLQkJCQkJCQkgICBj
bG9zZSBvbiBlbmQgKw0KKwkJCVdTRVQocGFyYW0sIDQsIDQgKyAyKTsJCS8q
IGNsb3NlIG9uIGVuZCArDQogCQkJCQkJCSAgIGNvbnRpbnVlICovDQogCQkJ
V1NFVChwYXJhbSwgNiwgaW5mb19sZXZlbCk7DQogCQkJRFNFVChwYXJhbSwg
OCwgMCk7DQpAQCAtMTYxNSw4ICsxNjE0LDcgQEANCiAJCQlXU0VUKHBhcmFt
LCAyLCBtYXhfbWF0Y2hlcyk7CS8qIG1heCBjb3VudCAqLw0KIAkJCVdTRVQo
cGFyYW0sIDQsIGluZm9fbGV2ZWwpOw0KIAkJCURTRVQocGFyYW0sIDYsIGZm
X3Jlc3VtZV9rZXkpOwkvKiBmZl9yZXN1bWVfa2V5ICovDQotCQkJV1NFVChw
YXJhbSwgMTAsIDggKyA0ICsgMik7CS8qIHJlc3VtZSByZXF1aXJlZCArDQot
CQkJCQkJCSAgIGNsb3NlIG9uIGVuZCArDQorCQkJV1NFVChwYXJhbSwgMTAs
IDQgKyAyKTsJCS8qIGNsb3NlIG9uIGVuZCArDQogCQkJCQkJCSAgIGNvbnRp
bnVlICovDQogCQkJaWYgKHNlcnZlci0+bW50LT52ZXJzaW9uICYgU01CX0ZJ
WF9XSU45NSkNCiAJCQl7DQpAQCAtMTY4Nyw2ICsxNjg1LDEyIEBADQogCQkJ
Y2FzZSAyNTk6DQogIAkJCQlpZiAoZmZfbGFzdG5hbWUgPCByZXNwX2RhdGFf
bGVuKQ0KIAkJCQkJbWFza19sZW4gPSByZXNwX2RhdGFfbGVuIC0gZmZfbGFz
dG5hbWU7DQorCQkJCS8qIFRoZSBsYXN0bmFtZSBwb2ludGVyIHBvaW50cyB0
byB0aGUgcmVjb3JkLA0KKwkJCQkgICBub3QgdG8gdGhlIG5hbWUuICovDQor
CQkJCWxhc3RuYW1lICs9IDEyOw0KKwkJCQltYXNrX2xlbiAtPSAxMjsNCisJ
CQkJaWYobWFza19sZW4gPCAwKQ0KKwkJCQkJbWFza19sZW4gPSAwOw0KIAkJ
CQlicmVhazsNCiAJCQljYXNlIDE6DQogCQkJCS8qIFdpbiBOVCA0LjAgZG9l
c24ndCBzZXQgdGhlIGxlbmd0aCBieXRlICovDQo=
---1463780587-1719613331-942525082=:14414--

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/