Re: The whole bunch of unresolved symbols in 2.3.30pre5
Jakub Jelinek (jakub@redhat.com)
Fri, 3 Dec 1999 19:53:42 +0100
On Fri, Dec 03, 1999 at 01:08:25PM -0500, Benjamin C.R. LaHaise wrote:
> On Fri, 3 Dec 1999, Alan Cox wrote:
>
> > I thought Ben was working on getting all this stuff in ?
>
> Sorry, I've been a bit slow at getting the last bits done.
>
> > Are the patches for the shifts available anywhere ?
>
> Not the shifts alone. For a good chunk of them, I was hoping they'd come
> from the maintainers of the filesystems as they *do* need to be tested,
> and I only use 3 filesystems. So far, most filesystems have been caught
> over the last few releases.
>
> I'm not going to fi affs -- it needs to be properly updated to use the new
> generic_file_write code. Below is a patch for NTFS that is untested, only
> fixes the 64 bit glitches, but doesn't fix the udate_vm_cache gotchas.
> Does NTFS have a maintainer?
>
>
> - vol->clustersize=vol->blocksize*vol->clusterfactor;
> - if(vol->mft_clusters_per_record>0)
> - vol->mft_recordsize=
> - vol->clustersize*vol->mft_clusters_per_record;
> + vol->clustersize = vol->blocksize * vol->clusterfactor;
> + if (vol->mft_clusters_per_record > 0)
> + vol->mft_recordbits = vol->clustersize * vol->mft_clusters_per_record;
> else
> - vol->mft_recordsize=1<<(-vol->mft_clusters_per_record);
> + vol->mft_recordbits = -vol->mft_clusters_per_record;
> +
> + vol->mft_recordsize = 1 << vol->mft_recordbits;
> vol->index_recordsize=vol->clustersize*vol->index_clusters_per_record;
This does not look right to me in the case of mft_clusters_per_record > 0,
but to fix it one would need to know if all the values in question
(blocksize, clusterfactor and mft_clusters_per_record) are guaranteed to be
powers of 2 or not.
Cheers,
Jakub
___________________________________________________________________
Jakub Jelinek | jakub@redhat.com | http://sunsite.mff.cuni.cz/~jj
Linux version 2.3.18 on a sparc64 machine (1343.49 BogoMips)
___________________________________________________________________
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/