Re: Toshiba kbd patch

Vojtech Pavlik (vojtech@suse.cz)
Tue, 7 Dec 1999 00:56:36 +0100


On Mon, Dec 06, 1999 at 03:37:00PM -0800, Linus Torvalds wrote:

> > Here is my latest version of the patch for fixing bad Toshiba notebook
> > keyboards - making sure the PC keyboard delay is at least 250ms, which
> > seems to be a good thing for others with broken keyboards.
>
> Well, it looks reasonable, but at the very least the magic constant "25"
> would need to be something readable like "HZ/2" so that it would actually
> work on correctly other architectures than x86 too.
>
> Also, I'm really rather nervous about 250ms being too long. Are there any
> really good touch-typists out there? I can easily see somebody pressing
> the same key more than four times a second, and I'd hate to lose
> keystrokes for good typists. Please convince me this is safe..

It should be fine - if someone is typing fast, he's also generating
key releases and thus the condition won't be met. It guards against
consecutive presses only, which only happens with autorepeat.

-- 
Vojtech Pavlik
SuSE Labs

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/