Re: timer_bh behaviour incorrect for 2.2.13?

Andrea Arcangeli (andrea@suse.de)
Thu, 9 Dec 1999 20:03:49 +0100 (CET)


On Thu, 9 Dec 1999, William Montgomery wrote:

>
>I am having a difficult time with the patch to run_bottom_halves.
>I have the following:
> bh = bh_base;
^^^^^^^^^^^^^ remove
> while ((active = get_active_bhs())) {
> __sti();
> clear_active_bhs(active);
bh = bh_base;
^^^^^^^^^^^ insert
> do {
> if (active & 1)
> (*bh)();
> bh++;
> active >>= 1;
> } while (active);
> __cli();
> }

Move `bh = bh_base' before the do { } while loop.

>I left the __sti(); / __cli(); in the caller.

Remove both them. You don't need them.

Andrea

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/