Re: Ok, making ready for pre-2.4 and code-freeze..

Benjamin C.R. LaHaise (blah@kvack.org)
Sun, 19 Dec 1999 18:45:31 -0500 (EST)


On Sun, 19 Dec 1999, Harald Koenig wrote:

> On Dec 14, Alan Cox wrote:
>
> > Add isofs breaks on DVD (it has a 4Gig byte wrap problem on bigger disks)
>
> is this a limitation of the iso9660 specs or of the Linux implementation ?

Well, here's one that affects >32bit files on 32bit platforms...

-ben

diff -u clean/2.3.34-2/fs/isofs/inode.c 2.3.34-2/fs/isofs/inode.c
--- clean/2.3.34-2/fs/isofs/inode.c Fri Nov 12 16:21:09 1999
+++ 2.3.34-2/fs/isofs/inode.c Sun Dec 19 18:42:06 1999
@@ -927,7 +927,8 @@
int isofs_get_block(struct inode *inode, long iblock,
struct buffer_head *bh_result, int create)
{
- off_t b_off, offset, sect_size;
+ loff_t b_off;
+ unsigned offset, sect_size;
unsigned int firstext;
unsigned long nextino;
int i, err;
@@ -948,7 +949,7 @@
* blocks.
*/
if (b_off > inode->i_size) {
- off_t max_legal_read_offset;
+ loff_t max_legal_read_offset;

/* If we are *way* beyond the end of the file, print a message.
* Access beyond the end of the file up to the next page boundary
@@ -958,7 +959,7 @@
* I/O errors.
*/
max_legal_read_offset = (inode->i_size + PAGE_SIZE - 1)
- & ~(PAGE_SIZE - 1);
+ & ~(loff_t)(PAGE_SIZE - 1);
if (b_off >= max_legal_read_offset)
goto abort_beyond_end;
}
Only in 2.3.34-2/fs/isofs/: inode.c.orig

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/