Re: Bug in tkparse or the Serial PCMCIA Config.in?

Andrzej Krzysztofowicz (ankry@green.mif.pg.gda.pl)
Thu, 30 Dec 1999 14:16:26 +0100 (CET)

>
> When I step through the "PCMCIA serial device support" dialog
> in "make xconfig", I see two sets of dep_tristate selection
> options. None of them work. The first two (CONFIG_PCMCIA_SERIAL_CS
> and CONFIG_PCMCIA_SERIAL_CB) look okay but selecting an option
> doesn't succeed in enabling the radio button. The second redundant
> set of selection lines for CONFIG_PCMCIA_SERIAL_CS and
> CONFIG_PCMCIA_SERIAL_CS show all options grayed out (not selectable).
>
> Here's what shows up in my kconfig.tk file:
>
> dep_tristate $w.config.f 36 0 "PCMCIA serial device support"
> CONFIG_PCMCIA_SERIAL_CS
> dep_tristate $w.config.f 36 1 "CardBus serial device support"
> CONFIG_PCMCIA_SERIAL_CB
> dep_tristate $w.config.f 36 2 "PCMCIA serial device support"
> CONFIG_PCMCIA_SERIAL_CS
> dep_tristate $w.config.f 36 3 "CardBus serial device support"
> CONFIG_PCMCIA_SERIAL_CB

Which kernel version ?

xconfig "by design" does not accept multiple clauses setting the same config
vartiable. Even if they are dependent on opposite conditions.
Current xconfig (2.3.x), as exception, accepts such multiple clauses
for different architectures (different ARCH=... settings).

> I have checked the contents of linux/drivers/char/pcmcia/Config.in and
> as far as I can tell, everything is in order. Here is what is in my
> copy
> of the file:
>
> #
> # PCMCIA character device configuration
> #
>
> mainmenu_option next_comment
> comment 'PCMCIA character device support'
>
> if [ "$CONFIG_SERIAL" = "y" ]; then
> dep_tristate 'PCMCIA serial device support' \
> CONFIG_PCMCIA_SERIAL_CS $CONFIG_PCMCIA
> if [ "$CONFIG_CARDBUS" = "y" ]; then
> dep_tristate 'CardBus serial device support' \
> CONFIG_PCMCIA_SERIAL_CB $CONFIG_PCMCIA
> fi
> fi
>
> if [ "$CONFIG_SERIAL" = "m" ]; then
> dep_tristate 'PCMCIA serial device support' \
> CONFIG_PCMCIA_SERIAL_CS m
> if [ "$CONFIG_CARDBUS" = "y" ]; then
> dep_tristate 'CardBus serial device support' \
> CONFIG_PCMCIA_SERIAL_CB m
> fi
> fi

This section is incompatible with xconfig. This should be changed or xconfig
should be removed/not used/replaced by another tool (mconfig ?)
If it is 2.3 kernel this section should be:

if [ "$CONFIG_SERIAL" = "y" -o "$CONFIG_SERIAL" = "m" ]; then
dep_tristate 'PCMCIA serial device support' \
CONFIG_PCMCIA_SERIAL_CS $CONFIG_PCMCIA $CONFIG_SERIAL
if [ "$CONFIG_CARDBUS" = "y" ]; then
dep_tristate 'CardBus serial device support' \
CONFIG_PCMCIA_SERIAL_CB $CONFIG_PCMCIA $CONFIG_SERIAL
fi
fi

> if [ "$CONFIG_PCMCIA_SERIAL_CS" = "y" -o \
> "$CONFIG_PCMCIA_SERIAL_CB" = "y" ]; then
> define_bool CONFIG_PCMCIA_CHRDEV y
> fi

define_bool is OK in this place.

-- 
=======================================================================
  Andrzej M. Krzysztofowicz               ankry@mif.pg.gda.pl
  phone (48)(58) 347 14 61
Faculty of Applied Phys. & Math.,   Technical University of Gdansk


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/