Re: hamachi driver question

From: Keith Underwood (keithu@parl.clemson.edu)
Date: Tue Mar 07 2000 - 10:27:05 EST


Well, yes and no. max_interrupt_work seems to be "how many interrupts can
we process for a given interrupt" whereas the boguscnt in hamachi_rx is
more of "we have an rx interrupt, how many packets can we receive".
Boguscnt should be based on how many packets an Rx interrupt can
represent (in theory).

                                        Keith

P.S. I've been working on the hamachi driver for a little while now. I
will be using the packet engines chips for another research effort, so I
decided finishing the cleanup of this driver was probably a good start at
understanding the chips ;-)

On Tue, 7 Mar 2000, Anton Ivanov wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
>
> Question:
> Isn't the initial bogus value in the hamachi_rx supposed to be
> max_interrupt_work? Or I am missing something?
>
> Suggested patch follows. Please cc me, I am not on the list, thanks in advance.
>
>
> *** hamachi.c 2000/03/07 10:09:58 1.1
> - --- hamachi.c 2000/03/07 10:13:25
> ***************
> *** 942,948 ****
> {
> struct hamachi_private *hmp = (struct hamachi_private *)dev->priv;
> int entry = hmp->cur_rx % RX_RING_SIZE;
> ! int boguscnt = 20;
>
> if (hamachi_debug > 4) {
> printk(KERN_DEBUG " In hamachi_rx(), entry %d status %4.4x.\n",
> - --- 942,948 ----
> {
> struct hamachi_private *hmp = (struct hamachi_private *)dev->priv;
> int entry = hmp->cur_rx % RX_RING_SIZE;
> ! int boguscnt = max_interrupt_work;
>
> if (hamachi_debug > 4) {
> printk(KERN_DEBUG " In hamachi_rx(), entry %d status %4.4x.\n",
>
> - ----------------------------------
> Anton R. Ivanov
> IP Engineer Level3 Communications
> RIPE: ARI2-RIPE E-Mail: Anton Ivanov <aivanov@eu.level3.net>
> @*** Parkinson's Laws (No 2 of 4) ***
> Expenditures rise to meet income.
>
> - ----------------------------------
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.0.0 (GNU/Linux)
> Comment: For info see http://www.gnupg.org
>
> iQEVAwUBOMTaGylWAw/bM84zAQHkSQf5AXWxld9uCxv3WcBwfCKv8HTcJnLXRL0Y
> zTWFjq5aeXGBpljcv4RgxEG5T3Hz1c7BneiIMLhtIAU6VpPWMeau4oumc3BCdrp3
> mRMwESUTZwa7lVlOQHxF0U5IClLZHgJJ1hIasYemw9UqmRosq2at409oysU8Xlq/
> aPY9UY0LAlMEScJVqhnR6WyFjc5a6+xMO1cAhYBxyQncA4/xATsuHVy5RwI/rvX1
> IGXgQqabFG4LLr5GPhLzXbZAlvXsy81yOLPLMfShc9NQyDE/5C7RKGAHihm9fHc8
> HfjfgPlbSziaPAf5o7ftpyLDvhGWuk+hmhDyadusoB9HbcBV5aoNjw==
> =qj9S
> -----END PGP SIGNATURE-----
> -
> To unsubscribe from this list: send the line "unsubscribe linux-net" in
> the body of a message to majordomo@vger.rutgers.edu
>

-
To unsubscribe from this list: send the line "unsubscribe linux-net" in
the body of a message to majordomo@vger.rutgers.edu



This archive was generated by hypermail 2b29 : Tue Mar 07 2000 - 21:00:27 EST