slight bug in e1000

From: Ben Greear (greearb@candelatech.com)
Date: Sun Aug 25 2002 - 12:57:48 EST


I just noticed this in e1000_ethtool.c (2.4.20-pre4):

static int
e1000_ethtool_geeprom(struct e1000_adapter *adapter,
                       struct ethtool_eeprom *eeprom, uint16_t *eeprom_buff)
{
        struct e1000_hw *hw = &adapter->hw;
        int i, max_len, first_word, last_word;

        if(eeprom->len == 0) return;

The return value should probably be zero or an error code. Definately
not undefined as it is now.

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>       <Ben_Greear AT excite.com>
President of Candela Technologies Inc      http://www.candelatech.com
ScryMUD:  http://scry.wanfear.com     http://scry.wanfear.com/~greear

- To unsubscribe from this list: send the line "unsubscribe linux-net" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html



This archive was generated by hypermail 2b29 : Sat Aug 31 2002 - 22:00:01 EST