Re: [PATCH 2.5.67] Update VLAN to new module semantics

From: David S. Miller (davem@redhat.com)
Date: Tue Apr 08 2003 - 17:25:27 EST


   From: Stephen Hemminger <shemminger@osdl.org>
   Date: Tue, 8 Apr 2003 11:28:05 -0700

            /* NOTE: We have a reference to the real device,
             * so hold on to the reference.
             */
   - MOD_INC_USE_COUNT; /* Add was a success!! */
   + try_module_get(THIS_MODULE);
   +

You have to check the return value and error accordingly.
The administrator can do a waiting module unload which causes
all try_module_get()'s to fail so that no new references can
be added to the module.

Please, if you're going to convert things, do it correctly.
-
To unsubscribe from this list: send the line "unsubscribe linux-net" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html



This archive was generated by hypermail 2b29 : Tue Apr 15 2003 - 22:00:01 EST