Re: [PATCH 2.5.67] Update VLAN to new module semantics

From: David S. Miller (davem@redhat.com)
Date: Tue Apr 08 2003 - 18:01:18 EST


   From: Stephen Hemminger <shemminger@osdl.org>
   Date: Tue, 8 Apr 2003 16:03:23 -0700

   On Tue, 08 Apr 2003 15:25:27 -0700 (PDT)
   "David S. Miller" <davem@redhat.com> wrote:
   
> You have to check the return value and error accordingly.
> The administrator can do a waiting module unload which causes
> all try_module_get()'s to fail so that no new references can
> be added to the module.
>
> Please, if you're going to convert things, do it correctly.
   
   That's what I get for copying bugs from other code ...
   
   Here is a repost which handles the race of unload and uncompleted init.

This looks a lot better, I'll further review this and apply
it unless I find some problems.

Thanks.
-
To unsubscribe from this list: send the line "unsubscribe linux-net" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html



This archive was generated by hypermail 2b29 : Tue Apr 15 2003 - 22:00:01 EST