Re: Question about QOS

From: David S. Miller
Date: Tue May 03 2005 - 16:52:27 EST


On Fri, 29 Apr 2005 14:16:50 +0200
Patrick McHardy <kaber@xxxxxxxxx> wrote:

> Thomas Graf wrote:
> > * Nicolas DICHTEL <426F42F0.9020609@xxxxxxxxx> 2005-04-27 09:44
> >
> >>>Yes I agree, it doesn't really matter what value we return and `bound'
> >>>is most likely to be correct. I think we should also fix the unlikely
> >>>but still possible case when tv1.tv_usec is slightly smaller than
> >>>tv2.tv_usec. I know it is very unlikely but do_gettimeofday really
> >>>is not that reliable and we have users which rely on a positive
> >>>delta. Can you extend your patch to return abs(delta) for case 0
> >>>in PSCHED_TDIFF_SAFE?
>
> Why abs(delta)? It could be above bound, in fact all cases besides
> delta_sec > 2 doesn't take care to stay inside [0..bound] at all.

Applied, thanks Patrick.
-
To unsubscribe from this list: send the line "unsubscribe linux-net" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html