Re: 2.2.2-ac7 TCP ignores ICMP host unreachable ??

Andi Kleen (ak@muc.de)
Mon, 8 Mar 1999 21:29:18 +0100


On Mon, Mar 08, 1999 at 08:44:41PM +0100, kuznet@ms2.inr.ac.ru wrote:
> Hello!
>
> > So there is a *different* behaviour between 2.0.36 and 2.2.2-ac7.
> > (another option would be that the ICMPs returned on the SYN packets from
> > 2.2.2-ac7 (with all those TCP options) get garbled in a different way
> > than the simpler 2.0.36 SYN packets ...)
>
> Yes, I see the reason. Router is not broken, it is my routers that
> are too good to see this bug. 8) Patch is appended.

Woo, another bug. Forgot to increase IcmpInErrors.
> + if (!no_flags && !th->syn && !th->ack)
> return;
{
icmp_statistics.IcmpInErrors++;
return;
}

instead.

Thanks for spotting that nasty.

-Andi

-- 
This is like TV. I don't like TV.
-
To unsubscribe from this list: send the line "unsubscribe linux-net" in
the body of a message to majordomo@vger.rutgers.edu