Re: [PATCH][2.6.8-rc1-mm1] drivers/scsi/sg.c gcc341 inlining fix

[Jeff Garzik]

Bartlomiej Zolnierkiewicz wrote:
> Hi,
>
> On Wednesday 14 of July 2004 14:16, Mikael Pettersson wrote:
>
> > gcc-3.4.1 errors out in 2.6.8-rc1-mm1 at drivers/scsi/sg.c:
> >
> > drivers/scsi/sg.c: In function `sg_ioctl':
> > drivers/scsi/sg.c:209: sorry, unimplemented: inlining failed in call to
> > 'sg_jif_to_ms': function body not available drivers/scsi/sg.c:930: sorry,
> > unimplemented: called from here
> > make[2]: *** [drivers/scsi/sg.o] Error 1
> > make[1]: *** [drivers/scsi] Error 2
> > make: *** [drivers] Error 2
> >
> > sg_jif_to_ms() is marked inline but used defore its function
> > body is available. Moving it nearer the top of sg.c (together
> > with sg_ms_to_jif() for consistency) fixes the problem.
>
>
> While your patch is perfectly fine I think we can do better.
> I think that we may try converting sg.c to use jiffies_to_msecs()
> and msecs_to_jiffies() from <linux/time.h>.


_Look_ at the patch.  It just moves code around for no reason.  Using 
static inline prototypes should work just fine.  This patch isn't needed.

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/