Re: [PATCH net-next] net: dsa: realtek: make interface drivers depend on OF

[Alvin Šipraga]

On Wed, Mar 23, 2022 at 08:39:53AM -0700, Jakub Kicinski wrote:
> On Wed, 23 Mar 2022 13:48:56 +0000 Alvin Šipraga wrote:
> > The driver has been split in net-next and deviates significantly from
> > what is in net. I can send a patch to net as well, but that will not
> > cover net-next.
> > 
> > View from net:
> > 
> >     drivers/net/dsa/Kconfig:
> >     ...
> >     config NET_DSA_REALTEK_SMI
> >     ...
> > 
> > View from net-next:
> > 
> >     drivers/net/dsa/Kconfig:
> >     ...
> >     source "drivers/net/dsa/realtek/Kconfig"
> >     ...
> > 
> >     drivers/net/dsa/realtek/Kconfig:
> >     menuconfig NET_DSA_REALTEK
> >         ...
> >     config NET_DSA_REALTEK_MDIO
> >         ...
> >     config NET_DSA_REALTEK_SMI
> >         ...
> > 
> > I am not well-versed in the procedures here, but since 5.17 has now been
> > released, isn't it more important to fix 5.18, which will soon have the
> > net-next branch merged in? Hence the patch should target net-next?
> > 
> > As for 5.17 and the old (net) structure, I can send a separate patch to
> > net. Does that sound OK?
> > 
> > Once that is clarified I can re-send with a Fixes: tag.
> 
> Just reply with a Fixes tag, I'll sort it out. I'm about to merge 
> the trees so it's a little bit of a special situation.

Thanks Jakub.

Strictly speaking the Fixes: is this:

Fixes: aac94001067d ("net: dsa: realtek: add new mdio interface for drivers")

But the problem existed before that, just in a form unapplicable to
net-next. See my reply to Andrew...

Kind regards,
Alvin