Re: [PATCH] bnx2x: replace usage of found with dedicated list iterator variable
From: Paolo Abeni
Date: Thu Mar 24 2022 - 06:46:23 EST
Hello,
On Thu, 2022-03-24 at 08:08 +0100, Jakob Koschel wrote:
> To move the list iterator variable into the list_for_each_entry_*()
> macro in the future it should be avoided to use the list iterator
> variable after the loop body.
>
> To *never* use the list iterator variable after the loop it was
> concluded to use a separate iterator variable instead of a
> found boolean [1].
>
> This removes the need to use a found variable and simply checking if
> the variable was set, can determine if the break/goto was hit.
>
> Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@xxxxxxxxxxxxxx/
> Signed-off-by: Jakob Koschel <jakobkoschel@xxxxxxxxx>
This looks like a purely net-next change, and we are in the merge
window: net-next is closed for the time being. Could you please re-post
after net-next re-open?
Additionally, I suggest you to bundle the net-next patches in a single
series, namely:
bnx2x: replace usage of found with dedicated list iterator variable
octeontx2-pf: replace usage of found with dedicated list iterator variable
sctp: replace usage of found with dedicated list iterator variable
taprio: replace usage of found with dedicated list iterator variable
that will simplify the processing, thanks!
Paolo