Re: [PATCH v3] mm/vmstat: add events for ksm cow

From: Matthew Wilcox
Date: Thu Mar 24 2022 - 08:45:57 EST


On Thu, Mar 24, 2022 at 10:43:33AM +0000, cgel.zte@xxxxxxxxx wrote:
> +++ b/include/linux/vm_event_item.h
> @@ -131,6 +131,7 @@ enum vm_event_item { PGPGIN, PGPGOUT, PSWPIN, PSWPOUT,
> SWAP_RA_HIT,
> #ifdef CONFIG_KSM
> KSM_SWPIN_COPY,
> + COW_KSM,

Shouldn't we call this KSM_COW?

> +++ b/mm/vmstat.c
> @@ -1390,6 +1390,7 @@ const char * const vmstat_text[] = {
> "swap_ra_hit",
> #ifdef CONFIG_KSM
> "ksm_swpin_copy",
> + "cow_ksm",

... and this "ksm_cow"?