Re: [PATCH] media: uvc_v4l2: fix possible memory leak in uvc_ioctl_ctrl_map

From: Ricardo Ribalda
Date: Thu Mar 24 2022 - 13:17:36 EST


Isnt it a dupe of:
https://patchwork.linuxtv.org/project/linux-media/patch/20211008120914.69175-1-ribalda@xxxxxxxxxxxx/
?

On Thu, 24 Mar 2022 at 18:13, Hangyu Hua <hbh25y@xxxxxxxxx> wrote:
>
> map->name needs to be freed when uvc_ioctl_ctrl_map fails.
>
> Signed-off-by: Hangyu Hua <hbh25y@xxxxxxxxx>
> ---
> drivers/media/usb/uvc/uvc_v4l2.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/usb/uvc/uvc_v4l2.c b/drivers/media/usb/uvc/uvc_v4l2.c
> index 711556d13d03..e46a2f3b06cb 100644
> --- a/drivers/media/usb/uvc/uvc_v4l2.c
> +++ b/drivers/media/usb/uvc/uvc_v4l2.c
> @@ -93,6 +93,7 @@ static int uvc_ioctl_ctrl_map(struct uvc_video_chain *chain,
>
> kfree(map->menu_info);
> free_map:
> + kfree(map->name);
> kfree(map);
>
> return ret;
> --
> 2.25.1
>


--
Ricardo Ribalda