Re: [PATCH v2] x86/amd_nb: unexport amd_cache_northbridges()

[Borislav Petkov]

On Thu, Mar 24, 2022 at 05:57:29PM +0530, Naveen Krishna Chatradhi wrote:
> From: Muralidhara M K <muralimk@xxxxxxx>
> 
> amd_cache_northbridges() is exported by amd_nb.c and is used by
> amd64-agp.c and amd64_edac.c modules.
> 
> init_amd_nbs() already calls amd_cache_northbridges() unconditionally,
> during fs_initcall() phase, which happens before the device_initcall().

No, that's not even trying. I went and did your work for you. Please
try harder in the future to really really explain why you're doing what
you're doing so that a reader of your commit message can easily follow
your logic and not have to do research just to figure out why your
change is ok.

---