RE: [PATCH] rtlwifi: replace usage of found with dedicated list iterator variable

[Pkshih]

> -----Original Message-----
> From: Jakob Koschel <jakobkoschel@xxxxxxxxx>
> Sent: Thursday, March 24, 2022 3:21 PM
> To: Pkshih <pkshih@xxxxxxxxxxx>
> Cc: Kalle Valo <kvalo@xxxxxxxxxx>; David S. Miller <davem@xxxxxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>;
> Paolo Abeni <pabeni@xxxxxxxxxx>; linux-wireless@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; Mike Rapoport <rppt@xxxxxxxxxx>; Brian Johannesmeyer
> <bjohannesmeyer@xxxxxxxxx>; Cristiano Giuffrida <c.giuffrida@xxxxx>; Bos, H.J. <h.j.bos@xxxxx>; Jakob
> Koschel <jakobkoschel@xxxxxxxxx>
> Subject: [PATCH] rtlwifi: replace usage of found with dedicated list iterator variable
> 
> To move the list iterator variable into the list_for_each_entry_*()
> macro in the future it should be avoided to use the list iterator
> variable after the loop body.
> 
> To *never* use the list iterator variable after the loop it was
> concluded to use a separate iterator variable instead of a
> found boolean [1].
> 
> This removes the need to use a found variable and simply checking if
> the variable was set, can determine if the break/goto was hit.
> 
> Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@xxxxxxxxxxxxxx/
> Signed-off-by: Jakob Koschel <jakobkoschel@xxxxxxxxx>

Acked-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>

Thanks.

[...]