Re: [PATCH 2/3] block: factor out common code for part_stat_show() and diskstats_show()
From: Christoph Hellwig
Date: Fri Mar 25 2022 - 04:46:36 EST
On Thu, Mar 17, 2022 at 07:26:52PM +0800, Yu Kuai wrote:
> part_stat_show() and diskstats_show() are very similar, just factor out
> common code.
Well, it doesn't really "factor" much, but creates a big and pretty
unmaintainble macro. I don't really see the benefit here.