Re: [GIT PULL] locking changes for v5.18
From: Andy Shevchenko
Date: Fri Mar 25 2022 - 07:42:09 EST
On Tue, Mar 22, 2022 at 03:58:47PM -0700, Linus Torvalds wrote:
> On Tue, Mar 22, 2022 at 3:20 PM Borislav Petkov <bp@xxxxxxxxx> wrote:
> >
> > Ah, you say build error because you have CONFIG_WERROR=y.
>
> EVERYBODY should have CONFIG_WERROR=y on at least x86-64 and other
> serious architectures, unless you have some completely random
> experimental (and broken) compiler.
>
> New compiler warnings are not acceptable.
What about old one? I have already complained in the early discussion that
`make W=1 ...` is broken by this change. Enabling it without fixing
_existing_ warnings on W=1 is not suitable for somebody. Now, I have to
modify my configs to disable WERROR because of inability to built at all.
(Yes, I understand that I may drop W=1, but that's not the point. since I
want to have clean builds of a new code on level 1 of warnings)
--
With Best Regards,
Andy Shevchenko