Re: [PATCH V2] arm64: dts: qcom: sc7280-idp: Configure cts sleep pinctrl to bias-bus-hold

[Doug Anderson]

Hi,

On Fri, Mar 25, 2022 at 7:06 AM Vijaya Krishna Nivarthi
<quic_vnivarth@xxxxxxxxxxx> wrote:
>
> WLAN rail was leaking power during RBSC/sleep even after turning BT off.
> Change sleep pinctrl configuration to handle same.
>
> Signed-off-by: Vijaya Krishna Nivarthi <quic_vnivarth@xxxxxxxxxxx>
> ---
> v2: used bias-bus-hold as per review comments
> v1: intial patch used bias-disable
> ---
>  arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

No objections from me now. ...but we should probably be changing _all_
of them? ...and by "all" I mean _both_ the sleep and wake state of the
pins and this config across all the devices. In the very least all the
sc7280 ones, but maybe even the sc7180 ones.

$ git grep "Configure a pull-down on CTS" -- arch/arm64/boot/dts
arch/arm64/boot/dts/qcom/sc7180-idp.dts:                 * Configure a
pull-down on CTS to match the pull of
arch/arm64/boot/dts/qcom/sc7180-idp.dts:                         *
Configure a pull-down on CTS to match the pull of
arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi:            * Configure a
pull-down on CTS to match the pull of
arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi:                    *
Configure a pull-down on CTS to match the pull of
arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r0.dts:      *
Configure a pull-down on CTS to match the pull of
arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r0.dts:
  * Configure a pull-down on CTS to match the pull of
arch/arm64/boot/dts/qcom/sc7280-idp.dtsi:        * Configure a
pull-down on CTS to match the pull of
arch/arm64/boot/dts/qcom/sc7280-idp.dtsi:                * Configure a
pull-down on CTS to match the pull of
arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi:     /* Configure a
pull-down on CTS to match the pull of the Bluetooth module. */
arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi:              * Configure a
pull-down on CTS to match the pull of

-Doug