Re: [PATCH 1/3] perf lock: Add --synth=no option for record
From: Arnaldo Carvalho de Melo
Date: Fri Mar 25 2022 - 15:35:56 EST
Em Wed, Mar 23, 2022 at 04:02:57PM -0700, Namhyung Kim escreveu:
> The perf lock command has nothing to symbolize and lock names come
> from the tracepoint. Moreover, kernel symbols are available even the
> --synth=no option is given.
>
> This will reduce the startup time by avoiding unnecessary synthesis.
Thanks, applied the series.
- Arnaldo
> Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxxx>
> ---
> tools/perf/builtin-lock.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/builtin-lock.c b/tools/perf/builtin-lock.c
> index 57b9ebd7118a..1ebff88bc5ba 100644
> --- a/tools/perf/builtin-lock.c
> +++ b/tools/perf/builtin-lock.c
> @@ -990,7 +990,7 @@ static int __cmd_report(bool display_info)
> static int __cmd_record(int argc, const char **argv)
> {
> const char *record_args[] = {
> - "record", "-R", "-m", "1024", "-c", "1",
> + "record", "-R", "-m", "1024", "-c", "1", "--synth", "no",
> };
> unsigned int rec_argc, i, j, ret;
> const char **rec_argv;
> --
> 2.35.1.894.gb6a874cedc-goog
--
- Arnaldo