Re: [PATCH v3 0/4] Fixes for TPM interrupt handling

[Lino Sanfilippo]

Hi Michael,

On 25.03.22 at 13:32, Michael Niewöhner wrote:
>>>
>>> Lino, I'd be happy to test the patches, when you have time and interest to
>>> work
>>> on this again!
>>>
>>> Thanks, Michael
>>
>> It's quite easy to test them out. Both fixes are in the mainline GIT tree.
>> E.g. give a shot rc1, and please report if any issues persists to:
>>
>>   linux-integrity@xxxxxxxxxxxxxxx 
>>
>> BR, Jarkko
>
> I don't see Linos patches on mainline. Also, the series included four patches:
> [PATCH v3 0/4] Fixes for TPM interrupt handling
> [PATCH v3 1/4] tpm: Use a threaded interrupt handler
> [PATCH v3 2/4] tpm: Simplify locality handling
> [PATCH v3 3/4] tpm: Fix test for interrupts
> [PATCH v3 4/4] tpm: Only enable supported irqs
>
> Three of them are relevant for the interrupt problem, which is still present in
> mainline, as these patches were refused:
> [PATCH v3 1/4] tpm: Use a threaded interrupt handler
> [PATCH v3 2/4] tpm: Simplify locality handling
> [PATCH v3 3/4] tpm: Fix test for interrupts
>
> Michael
>

You are right, the interrupts are still not working in the mainline kernel.
I would gladly make another attempt to fix this but rather step by step
than in a series that tries to fix (different) things at once.

A first step could be to have a sleepable context for the interrupt handling,
since in case of SPI the accesses to the irq status register may sleep.

I sent a patch for this purpose once, but it seems to have gone lost:

https://lore.kernel.org/all/20210620023444.14684-1-LinoSanfilippo@xxxxxx/


Best regards,
Lino