[PATCH] scsi: ufs: fix itnull.cocci warnings
From: Julia Lawall
Date: Sat Mar 26 2022 - 04:35:51 EST
From: kernel test robot <lkp@xxxxxxxxx>
list_for_each_entry binds rgn to an entry, which cannot be NULL. So
remove the first test.
Generated by: scripts/coccinelle/iterators/itnull.cocci
Reported-by: kernel test robot <lkp@xxxxxxxxx>
Signed-off-by: kernel test robot <lkp@xxxxxxxxx>
Signed-off-by: Julia Lawall <julia.lawall@xxxxxxxx>
---
tree: https://github.com/bvanassche/linux ufs-for-next
head: b93e987f91a0c037fc4357107f5144110cd84d08
commit: b93e987f91a0c037fc4357107f5144110cd84d08 [324/324] scsi: ufs: Split the drivers/scsi/ufs directory
:::::: branch date: 11 hours ago
:::::: commit date: 11 hours ago
Please take the patch only if it's a positive warning. Thanks!
drivers/scsi/ufs-core/ufshpb.c | 6 ------
1 file changed, 6 deletions(-)
--- a/drivers/scsi/ufs-core/ufshpb.c
+++ b/drivers/scsi/ufs-core/ufshpb.c
@@ -875,12 +875,6 @@ static struct ufshpb_region *ufshpb_vict
struct ufshpb_region *rgn, *victim_rgn = NULL;
list_for_each_entry(rgn, &lru_info->lh_lru_rgn, list_lru_rgn) {
- if (!rgn) {
- dev_err(&hpb->sdev_ufs_lu->sdev_dev,
- "%s: no region allocated\n",
- __func__);
- return NULL;
- }
if (ufshpb_check_srgns_issue_state(hpb, rgn))
continue;