Re: [PATCH 2/4] hwmon: (asus-ec-sensors) implement locking via the ACPI global lock

From: Guenter Roeck
Date: Sun Mar 27 2022 - 14:04:23 EST


On 3/27/22 09:21, Eugene Shalygin wrote:
On Sun, 27 Mar 2022 at 14:15, Eugene Shalygin <eugene.shalygin@xxxxxxxxx> wrote:
+ /* number of board EC sensors */
+ u8 nr_sensors;

Re-added by mistake, will be fixed in the next patch version.

+ if (ACPI_FAILURE(status)) {
+ dev_err(dev,
+ "Failed to get hardware access guard AML mutex"
+ "'%s': error %d",
+ mutex_path, status);

Can't choose between various options to fix this broken string
literal. Would be thankful, Günter, for a suggestion.


What is the problem other than that the string is split across
multiple lines ? That can easily be fixed by not splitting it,
so you'll have to be more specific.

Guenter