Re: [net-next 2/5] net: mdio: of: use fwnode_mdiobus_* functions

[Clément Léger]

Le Fri, 25 Mar 2022 19:32:45 +0100,
Andrew Lunn <andrew@xxxxxxx> a écrit :

> On Fri, Mar 25, 2022 at 06:22:31PM +0100, Clément Léger wrote:
> > Now that fwnode support has been added and implements the same behavior
> > expected by device-tree parsing  
> 
> The problem is, we cannot actually see that. There is no side by side
> comparison which makes it clear it has the same behaviour.
> 
> Please see if something like this will work:
> 
> 1/4: copy drivers/net/mdio/of_mdio.c to drivers/net/mdio/fwnode_mdio.c
> 2/4: Delete from fwnode_mdio.c the bits you don't need, like the whitelist
> 3/4: modify what is left of fwnode_mdio.c to actually use fwnode.
> 4/4: Rework of_mdio.c to use the code in fwnode_mdio.c
> 
> The 3/4 should make it clear it has the same behaviour, because we can
> see what you have actually changed.

Indeed, that would be more clear to provide this as separate patches
that shows clearly the conversion. Will do that.

> 
> FYI: net-next is closed at the moment, so you need to post RFC
> patches.

Ok, I refered to http://vger.kernel.org/~davem/net-next.html which
seems wrong actually

> 
>     Andrew

Thanks

-- 
Clément Léger,
Embedded Linux and Kernel engineer at Bootlin
https://bootlin.com