Re: [PATCH 6/6] arm64: dts: qcom: sm8250: remove address cells from dsi nodes

[Krzysztof Kozlowski]

On 28/03/2022 16:30, Vinod Koul wrote:
> The child of dsi nodes do not have unit address, this causes warnings:
> 
> arch/arm64/boot/dts/qcom/sm8250.dtsi:3249.22-3301.6:
> 	Warning (avoid_unnecessary_addr_size): /soc@0/mdss@ae00000/dsi@ae94000:
> 	unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
> 
> arch/arm64/boot/dts/qcom/sm8250.dtsi:3322.22-3374.6:
> 	Warning (avoid_unnecessary_addr_size): /soc@0/mdss@ae00000/dsi@ae96000:
> 	unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
> 
> So remove #address-cells/#size-cells for dsi nodes.

I think this needs different fix and my review was not correct. MIPI DSI
is a bus, so it can have children with unit addresses.

This DTSI (and several others) should have address/size cells, so
downstream could add easily children (e.g. panel nodes).

However I don't know how to combine it with "ports" not having unit address.

Maybe Rob has some ideas?

Best regards,
Krzysztof