Re: [PATCH v2 1/2] dt-bindings: virtio: mmio: add optional wakeup-source property

From: Michael S. Tsirkin
Date: Mon Mar 28 2022 - 16:48:11 EST


On Fri, Mar 25, 2022 at 09:59:45AM +0800, Minghao Xue wrote:
> Some systems want to set the interrupt of virtio_mmio device
> as a wakeup source. On such systems, we'll use the existence
> of the "wakeup-source" property as a signal of requirement.
>
> Signed-off-by: Minghao Xue <quic_mingxue@xxxxxxxxxxx>

I don't have enough of a clue about dt to review this.
Pls get some acks from people with DT expertise.

> ---
> v1 -> v2: rename property from "virtio,wakeup" to "wakeup-source"
>
> Documentation/devicetree/bindings/virtio/mmio.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/virtio/mmio.yaml b/Documentation/devicetree/bindings/virtio/mmio.yaml
> index 4b7a027..160b21b 100644
> --- a/Documentation/devicetree/bindings/virtio/mmio.yaml
> +++ b/Documentation/devicetree/bindings/virtio/mmio.yaml
> @@ -31,6 +31,10 @@ properties:
> description: Required for devices making accesses thru an IOMMU.
> maxItems: 1
>
> + wakeup-source:
> + type: boolean
> + description: Required for setting irq of a virtio_mmio device as wakeup source.
> +
> required:
> - compatible
> - reg
> --
> 2.7.4