Re: Comments on new user events ABI
From: Beau Belgrave
Date: Mon Mar 28 2022 - 19:30:30 EST
> ----- On Mar 28, 2022, at 4:24 PM, Mathieu Desnoyers mathieu.desnoyers@xxxxxxxxxxxx wrote:
>
> > Hi Beau, Hi Steven,
> >
> > I've done a review of the trace events ABI, and I have a few comments.
> > Sorry for being late to the party, but I only noticed this new ABI recently.
> > Hopefully we can improve this ABI before the 5.18 release.
> >
>
> Also a bit of testing shows that dyn_event_add() is called without holding the event_mutex.
> Has this been tested with lockdep ?
Sorry, looks like I've been running with LOCKDEP_SUPPORT without it on :(
I now have both CONFIG_LOCKDEP and CONFIG_LOCK_DEBUGGING_SUPPORT.
You are right about this, thanks! I've sent a patch.
Link: https://lore.kernel.org/all/20220328223225.1992-1-beaub@xxxxxxxxxxxxxxxxxxx/
Thanks,
-Beau