Re: [PATCH] remoteproc: avoid array index out of bounds in debugfs file

From: Miles Chen
Date: Mon Mar 28 2022 - 22:48:19 EST


Hi Xiaobing,

> There is a negative offset of an on-stack array that causes an out of
> bounds issue when someone called with a zero 'count' argument to
> syswrite().
>
> buf[count - 1]
>
> We should add an extra check in rproc_coredump_write() to prevent the
> access.
>
> Signed-off-by: Xiaobing shi <xiaobing.shi@xxxxxxxxxxxx>

Thanks for the patch.
However, Alistair has fixed this issue:
https://lore.kernel.org/all/20220119232139.1125908-1-adelva@xxxxxxxxxx/

Thanks,
Miles