Re: mm: use mmap_assert_write_locked() instead of open coding it

From: Christoph Hellwig
Date: Tue Mar 29 2022 - 02:36:50 EST

Next message: Lukasz Luba: "Re: [RESEND][PATCH 7/8] thermal: cooling: Check Energy Model type in cpufreq_cooling and devfreq_cooling"
Previous message: kernel test robot: "[gustavoars:testing/kspp-stringop-overflow 5/5] arch/x86/mm/pgtable.c:442:27: warning: variable 'pmds' is uninitialized when used here"
In reply to: Rolf Eike Beer: "mm: use mmap_assert_write_locked() instead of open coding it"
Next in thread: Rolf Eike Beer: "Re: mm: use mmap_assert_write_locked() instead of open coding it"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Mon, Mar 28, 2022 at 10:24:51AM +0200, Rolf Eike Beer wrote:
> In case the lock is actually not held at this point this also avoids a
> stale lock reference if built with NDEBUG.

The change looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

But I don't think NDEBUG is a thing in the kernel.

Next message: Lukasz Luba: "Re: [RESEND][PATCH 7/8] thermal: cooling: Check Energy Model type in cpufreq_cooling and devfreq_cooling"
Previous message: kernel test robot: "[gustavoars:testing/kspp-stringop-overflow 5/5] arch/x86/mm/pgtable.c:442:27: warning: variable 'pmds' is uninitialized when used here"
In reply to: Rolf Eike Beer: "mm: use mmap_assert_write_locked() instead of open coding it"
Next in thread: Rolf Eike Beer: "Re: mm: use mmap_assert_write_locked() instead of open coding it"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]