Re: 答复: [PATCH V2] staging: r8188eu: Directly return _SUCCESS instead of using local ret variable

[baihaowen]

在 3/28/22 5:12 PM, Greg KH 写道:
> A: http://en.wikipedia.org/wiki/Top_post
> Q: Were do I find info about this thing called top-posting?
> A: Because it messes up the order in which people normally read text.
> Q: Why is top-posting such a bad thing?
> A: Top-posting.
> Q: What is the most annoying thing in e-mail?
>
> A: No.
> Q: Should I include quotations after my reply?
>
> http://daringfireball.net/2007/07/on_top
>
> On Mon, Mar 28, 2022 at 09:07:44AM +0000, 白浩文 wrote:
>> Hi, Greg KH
>>
>> Yes, I think sync rtl8723bs and r8188eu will be better as they have same problem.
>>
>> commit 067756acdac8e0dd91edf4800e844fcb6e0cc72a
>> Author: Hariprasad Kelam <hariprasad.kelam@xxxxxxxxx>
>> Date:   Mon Jul 15 23:16:18 2019 +0530
>>
>>     staging: rtl8723bs: core: Change return type of init_mlme_ext_priv
>>
>>     As init_mlme_ext_priv function always returns SUCCESS , We can change
>>     return type from int to void.
>>
>>     Fixes below issue identified by coccicheck
>>     drivers/staging/rtl8723bs/core/rtw_mlme_ext.c:464:5-8: Unneeded
>>     variable: "res". Return "_SUCCESS" on line 492
> Yes, that would be good.
>
ok, got and learned a lot as a newbie, thx.

-- 
Haowen Bai