Re: [PATCH 3/8] mm/vmscan: introduce helper function reclaim_page_list()

From: Christoph Hellwig
Date: Tue Mar 29 2022 - 10:00:39 EST

Next message: Christoph Hellwig: "Re: [PATCH 4/8] mm/vmscan: save a bit of stack space in shrink_lruvec"
Previous message: David Hildenbrand: "Re: [PATCH v2 01/15] mm/rmap: fix missing swap_free() in try_to_unmap() after arch_unmap_one() failed"
In reply to: Miaohe Lin: "Re: [PATCH 3/8] mm/vmscan: introduce helper function reclaim_page_list()"
Next in thread: Miaohe Lin: "Re: [PATCH 3/8] mm/vmscan: introduce helper function reclaim_page_list()"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

> +static inline unsigned int reclaim_page_list(struct list_head *page_list, struct pglist_data *pgdat)

This is completely unreadable with the crazy long lines.

Also why would you force inline this?

Next message: Christoph Hellwig: "Re: [PATCH 4/8] mm/vmscan: save a bit of stack space in shrink_lruvec"
Previous message: David Hildenbrand: "Re: [PATCH v2 01/15] mm/rmap: fix missing swap_free() in try_to_unmap() after arch_unmap_one() failed"
In reply to: Miaohe Lin: "Re: [PATCH 3/8] mm/vmscan: introduce helper function reclaim_page_list()"
Next in thread: Miaohe Lin: "Re: [PATCH 3/8] mm/vmscan: introduce helper function reclaim_page_list()"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]