Re: [PATCH 1/2] spi: dt-bindings: qcom,spi-geni-qcom: convert to dtschema
From: Rob Herring
Date: Tue Mar 29 2022 - 15:05:11 EST
On Tue, 29 Mar 2022 13:27:16 +0200, Krzysztof Kozlowski wrote:
> Convert the GENI based Qualcomm Universal Peripheral (QUP) Serial
> Peripheral Interface (SPI) bindings to DT Schema.
>
> The original bindings in TXT were not complete, so add during conversion
> properties already used in DTS and/or in the driver: reg-names, dmas,
> interconnects, operating points and power-domains.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---
> .../bindings/spi/qcom,spi-geni-qcom.txt | 39 ------
> .../bindings/spi/qcom,spi-geni-qcom.yaml | 131 ++++++++++++++++++
> 2 files changed, 131 insertions(+), 39 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.txt
> create mode 100644 Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.example.dt.yaml:0:0: /example-0/spi@880000/tpm@0: failed to match any schema with compatible: ['google,cr50']
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/1610589
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.