Re: [PATCH v2 3/4] KVM: x86/mmu: explicitly check nx_hugepage in disallowed_hugepage_adjust()
From: Sean Christopherson
Date: Tue Mar 29 2022 - 18:28:22 EST
On Tue, Mar 29, 2022, Sean Christopherson wrote:
> > Fixes: b8e8c8303ff2 ("kvm: mmu: ITLB_MULTIHIT mitigation")
> > Cc: stable@xxxxxxxxxxxxxxx
>
> I vote to keep the Fixes tag, but drop the Cc: stable@ and NAK any MANUALSEL/AUTOSEL
> for backporting this to stable trees. Yes, it's a bug, but the NX huge page zapping
> kthread will (eventually) reclaim the lost performance. On the flip side, if there's
> an edge case we mess up (see below), then we've introduced a far worse bug.
Doh, that's wrong. The whole problem is that these pages aren't on the NX list...
I think I'd still vote to not send this to stable, but it's a weak vote.