Re: [PATCH v11 1/8] dax: Introduce holder for dax_device
From: Christoph Hellwig
Date: Wed Mar 30 2022 - 01:42:13 EST
On Wed, Mar 16, 2022 at 09:46:07PM +0800, Shiyang Ruan wrote:
> > Forgive me if this has been discussed before, but since dax_operations
> > are in terms of pgoff and nr pages and memory_failure() is in terms of
> > pfns what was the rationale for making the function signature byte
> > based?
>
> Maybe I didn't describe it clearly... The @offset and @len here are
> byte-based. And so is ->memory_failure().
Yes, but is there a good reason for that when the rest of the DAX code
tends to work in page chunks?