Re: [PATCH v5 2/2] dt-bindings: mmc: xenon: Convert to JSON schema
From: Krzysztof Kozlowski
Date: Wed Mar 30 2022 - 03:20:57 EST
On 30/03/2022 00:05, Chris Packham wrote:
> Convert the marvell,xenon-sdhci binding to JSON schema. Currently the
> in-tree dts files don't validate because they use sdhci@ instead of mmc@
> as required by the generic mmc-controller schema.
>
> The compatible "marvell,sdhci-xenon" was not documented in the old
> binding but it accompanies the of "marvell,armada-3700-sdhci" in the
> armada-37xx SoC dtsi so this combination is added to the new binding
> document.
>
> Signed-off-by: Chris Packham <chris.packham@xxxxxxxxxxxxxxxxxxx>
> Reviewed-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> ---
>
> Notes:
> Changes in v5:
> - Fix silly error in examples
> Changes in v4:
> - Add review from Krzysztof
> - Squash in addition of marvell,sdhci-xenon with an explanation in the
> commit message
> Changes in v3:
> - Don't accept ap807 without ap806
> - Add ref: string for pad-type
> Changes in v2:
> - Update MAINTAINERS entry
> - Incorporate feedback from Krzysztof
>
> .../bindings/mmc/marvell,xenon-sdhci.txt | 173 -----------
> .../bindings/mmc/marvell,xenon-sdhci.yaml | 275 ++++++++++++++++++
> MAINTAINERS | 2 +-
> 3 files changed, 276 insertions(+), 174 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.txt
> create mode 100644 Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
Best regards,
Krzysztof