Re: [PATCH] zram_drv: add __GFP_NOWARN flag on call to zs_malloc

[Sergey Senozhatsky]

On (22/03/30 10:06), Michal Hocko wrote:
> On Wed 30-03-22 14:25:02, Jaewon Kim wrote:
> > The page allocation with GFP_NOIO may fail. And zram can handle this
> > allocation failure. We do not need to print log for this.
> 
> GFP_NOIO doesn't have any special meaning wrt to failures. zram
> allocates from the memory reclaim context which is a bad design IMHO.

Agreed.

> Is the memory allocation failure gracefully recoverable?

No, it's not. I agree that we want to see that allocation warning
in the logs.