Re: [PATCH net v2] ice: Fix MAC address setting

[Alexander Lobakin]

From: Jacob Keller <jacob.e.keller@xxxxxxxxx>
Date: Mon, 28 Mar 2022 17:53:19 +0000

Hey netdev maintainers,

> > -----Original Message-----
> > From: Ivan Vecera <ivecera@xxxxxxxxxx>
> > Sent: Friday, March 25, 2022 6:25 AM
> > To: netdev@xxxxxxxxxxxxxxx
> > Cc: poros <poros@xxxxxxxxxx>; mschmidt <mschmidt@xxxxxxxxxx>;
> > Brandeburg, Jesse <jesse.brandeburg@xxxxxxxxx>; Nguyen, Anthony L
> > <anthony.l.nguyen@xxxxxxxxx>; David S. Miller <davem@xxxxxxxxxxxxx>; Jakub
> > Kicinski <kuba@xxxxxxxxxx>; Paolo Abeni <pabeni@xxxxxxxxxx>; moderated
> > list:INTEL ETHERNET DRIVERS <intel-wired-lan@xxxxxxxxxxxxxxxx>; open list <linux-
> > kernel@xxxxxxxxxxxxxxx>
> > Subject: [PATCH net v2] ice: Fix MAC address setting
> > 
> > Commit 2ccc1c1ccc671b ("ice: Remove excess error variables") merged
> > the usage of 'status' and 'err' variables into single one in
> > function ice_set_mac_address(). Unfortunately this causes
> > a regression when call of ice_fltr_add_mac() returns -EEXIST because
> > this return value does not indicate an error in this case but
> > value of 'err' remains to be -EEXIST till the end of the function
> > and is returned to caller.
> > 
> > Prior mentioned commit this does not happen because return value of
> > ice_fltr_add_mac() was stored to 'status' variable first and
> > if it was -EEXIST then 'err' remains to be zero.
> > 
> > Fix the problem by reset 'err' to zero when ice_fltr_add_mac()
> > returns -EEXIST.
> > 
> > Fixes: 2ccc1c1ccc671b ("ice: Remove excess error variables")
> > Signed-off-by: Ivan Vecera <ivecera@xxxxxxxxxx>
> > ---
> 
> Thanks for the v2. This looks great. Good analysis of how this happened in the commit message, I appreciate that.
> 
> Reviewed-by: Jacob Keller <jacob.e.keller@xxxxxxxxx>

This is an urgent fix, so we would like it to go through -net, not
IWL.
It has this Reviewed-by, and also

Acked-by: Alexander Lobakin <alexandr.lobakin@xxxxxxxxx>

> 
> >  drivers/net/ethernet/intel/ice/ice_main.c | 7 +++++--
> >  1 file changed, 5 insertions(+), 2 deletions(-)
> > 

--- 8< ---

> > --
> > 2.34.1

Thanks,
Al