Re: [PATCH linux-next] RDMA: simplify if-if to if-else

[Haakon Bugge]

> On 30 Mar 2022, at 13:32, Leon Romanovsky <leon@xxxxxxxxxx> wrote:
> 
> On Wed, Mar 30, 2022 at 11:06:03AM +0000, Haakon Bugge wrote:
>> 
>> 
>>> On 30 Mar 2022, at 13:02, Leon Romanovsky <leon@xxxxxxxxxx> wrote:
>>> 
>>> On Mon, Mar 28, 2022 at 09:08:59PM +0800, Guo Zhengkui wrote:
>>>> `if (!ret)` can be replaced with `else` for simplification.
>>>> 
>>>> Signed-off-by: Guo Zhengkui <guozhengkui@xxxxxxxx>
>>>> ---
>>>> drivers/infiniband/hw/irdma/puda.c | 4 ++--
>>>> drivers/infiniband/hw/mlx4/mcg.c   | 3 +--
>>>> 2 files changed, 3 insertions(+), 4 deletions(-)
>>>> 
>>> 
>>> Thanks,
>>> Reviewed-by: Leon Romanovsky <leonro@xxxxxxxxxx>
>> 
>> Fix the unbalanced curly brackets at the same time?
> 
> I think that it is ok to have if () ... else { ... } code.


Hmm, doesn't the kernel coding style say:

"Do not unnecessarily use braces where a single statement will do."

[snip]

"This does not apply if only one branch of a conditional statement is a single statement; in the latter case use braces in both branches"


Thxs, Håkon


> 
> There is one place that needs an indentation fix, in mlx4, but it is
> faster to fix when applying the patch instead of asking to resubmit.
> 
> thanks
> 
>> 
>> 
>> Thxs, Håkon