Re: [PATCH v2] mm/list_lru: Fix possible race in memcg_reparent_list_lru_node()

From: Shakeel Butt
Date: Thu Mar 31 2022 - 02:40:06 EST


On Wed, Mar 30, 2022 at 07:48:45PM -0700, Roman Gushchin wrote:
>
>
[...]
>
>
> But honestly, I’d drop the original optimization together with the fix, if only there is no _real world_ data on the problem and the improvement. It seems like it has started as a nice simple improvement, but the race makes it complex and probably not worth the added complexity and fragility.

I agree with dropping the original optimization as it is not really
fixing an observed issue which may justify adding some complexity.

thanks,
Shakeel